Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 11: Remove JavaDoc Links #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nikos410
Copy link
Contributor

Hello @mjiderhamn,

since the first PR I've opened for Java 11 compatibility (#87) looks really cluttered, with multiple commits to the same file that sometimes revert each other, I'm splitting the changes into smaller PRs.

Here, I've removed the links to some packages in some JavaDoc comments, because these packages cannot be accessed directly anymore in with Java 11.

@mjiderhamn
Copy link
Owner

Hi @Nikos410 . Is there a problem with the build (or other tooling) if the packages can no longer be accessed?
Or is this something more aesthetic from your point of view?

@Nikos410
Copy link
Contributor Author

Hi, thanks for your reply!

With the links in place, some tests error with the message "Missing code implementation in the compiler" when I run them locally in Eclipse or with mvn test. This does not seem to affect the Travis builds, however.

So I guess it is not neccessary to change this, since I could just remove the links when developing locally and put them back in place before committing - This is probably a matter of opinion, if it is better to have the links in place to conveniently browse the documentation but having to go through this additional step every time.

@ArloL
Copy link
Contributor

ArloL commented Dec 17, 2018

It works on Travis because JavaDoc is never built there since the build is called like this

./mvnw install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
./mvnw test -B

as explained in Travis Java Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants