add TransportDirect transport #153
Conversation
|
@mjl- this is my second attempt to fix #149. This time by adding a new transport for direct connections as we talked in https://github.com/mjl-/mox/issues/149#issuecomment-2041007381 |
|
nice, this looks like a good solution. i think the other PR is also still useful, right? will have another look there too. i've got a few small comments on this pr, will show up in a moment. |
There was a problem hiding this comment.
this seems like a nice way to solve the issue. i also saw that using GatherIPs to filter the IPs returns the expected value of dualstack (for the retries around issues with ipv4/ipv6). and gatherips is relatively easy to test. no open/known issues with this, right?
The `TransportDirect` transport allows to tweak outgoing SMTP
connections to remote servers. Currently, it only allows to select
network IP family (ipv4, ipv6 or both).
For example, to disable ipv6 for all outgoing SMTP connections:
- add these lines in mox.conf to create a new transport named
"disableipv6":
```
Transports:
disableipv6:
Direct:
DisableIpv6: true
```
- then add these lines in domains.conf to use this transport:
```
Routes:
-
Transport: disableipv6
```
fix #149
The other PR might still be useful as it works without any configuration, but if both PR are merge I would still prefer to use the transportDirect configuration (for the reasons mentioned on the other PR). |
|
merged, thanks! fyi, i ran "make genapidiff" afterwards. the smtpclient.GatherIPs changes the api. |
The
TransportDirecttransport allows to tweak outgoing SMTP connections to remote servers. Currently, it only allows to select network IP family (ipv4, ipv6 or both).For example, to disable ipv6 for all outgoing SMTP connections:
fix #149