Skip to content

Commit

Permalink
Dockerfile: python3 setup.py install is deprecated
Browse files Browse the repository at this point in the history
https://packaging.python.org/en/latest/discussions/setup-py-deprecated

Let's try `pip install --editable .` instead.

Also, `pip` now has a real dependency resolver to provide it all dependencies in a single command.

Why not put `libmagic` and `urllib3` in `setup.py`'s `install_requires` list?
  • Loading branch information
cclauss authored Mar 26, 2024
1 parent d5406df commit d01568e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ WORKDIR /workbench
RUN python -m pip install setuptools

# RUN pip install filemagic
RUN pip install urllib3>=1.21.1
RUN pip install libmagic
RUN python setup.py install
RUN pip install libmagic urllib3>=1.21.1
RUN pip install --editable .

0 comments on commit d01568e

Please sign in to comment.