Merge pull request #778 from seth-shaw-asu/merleaux-virks

Make empty field checks pythonic
mjordan · May 15, 2024 · e7e55ca · e7e55ca
2 parents c197de3 + b720efb
commit e7e55ca
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/workbench_fields.py b/workbench_fields.py
@@ -57,7 +57,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if field_name in config["field_text_format_ids"]:
@@ -124,7 +124,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if field_name in config["field_text_format_ids"]:
@@ -336,7 +336,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -386,7 +386,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if config["task"] == "update_terms":
@@ -530,7 +530,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -581,7 +581,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if config["task"] == "update_terms":
@@ -731,7 +731,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -802,7 +802,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if config["task"] == "update_terms":
@@ -984,7 +984,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -1041,7 +1041,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if config["task"] == "update_terms":
@@ -1208,7 +1208,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -1254,7 +1254,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if config["task"] == "update_terms":
@@ -1411,7 +1411,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -1460,7 +1460,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         cardinality = int(field_definitions[field_name].get("cardinality", -1))
@@ -1616,7 +1616,7 @@ def create(self, config, field_definitions, entity, row, field_name):
          dictionary
              A dictionary represeting the entity that is POSTed to Drupal as JSON.
         """
-        if row[field_name] is None:
+        if not row[field_name]:
             logging.warning(f'Did not find "{field_name}" in row.')
             return entity
         id_field = row.get(config.get("id_field", "not_applicable"), "not_applicable")
@@ -1855,7 +1855,7 @@ def update(
             entity[field_name] = []
             return entity
 
-        if row[field_name] is None:
+        if not row[field_name]:
             return entity
 
         if config["update_mode"] == "replace":