Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added override to assign media types by media use #837

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

ajstanley
Copy link
Contributor

Link to Github issue or other discussion

Addresses issue 836

What does this PR do?

Allows definition of media types

What changes were made?

Added and implemented media_type_by_media_use config
(also threw in a parameter to allow harvesting i7 data from a list of PIDS)

How to test / verify this PR?

add this to config if additional fields have been defined. Test files should now be of correct media type

media_type_by_media_use:
  - https://projects.iq.harvard.edu/fits: fits_technical_metadata
additional_files:
 - extracted: http://pcdm.org/use#ExtractedText
 - fits: https://projects.iq.harvard.edu/fits
 - service: http://pcdm.org/use#ServiceFile
 - thumbnail: http://pcdm.org/use#ThumbnailImage

Interested Parties

** @mjordan**


Checklist

  • Before opening this PR, have you opened an issue explaining what you want to to do?
  • Have you included some configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • Does the code added in this PR require a version of Python that is higher than the current minimum version?
  • If the changes in this PR require an additional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

@mjordan
Copy link
Owner

mjordan commented Oct 29, 2024

@ajstanley would you mind sketching out a new section of the docs at https://mjordan.github.io/islandora_workbench_docs/media_types/ for this new feature?

@ajstanley
Copy link
Contributor Author

ajstanley commented Oct 29, 2024 via email

@mjordan mjordan merged commit dacfe2d into mjordan:main Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants