Skip to content

Commit

Permalink
Add format selection criteria longside, shortside (ytdl-org#30737)
Browse files Browse the repository at this point in the history
  • Loading branch information
mk-pmb committed Jan 11, 2024
1 parent be008e6 commit 5a2aca1
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion youtube_dl/YoutubeDL.py
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ class YoutubeDL(object):
'duration', 'view_count', 'like_count', 'dislike_count', 'repost_count',
'average_rating', 'comment_count', 'age_limit',
'start_time', 'end_time',
'longside', 'shortside',
'chapter_number', 'season_number', 'episode_number',
'track_number', 'disc_number', 'release_year',
'playlist_index',
Expand Down Expand Up @@ -1207,7 +1208,7 @@ def _build_format_filter(self, filter_spec):
'!=': operator.ne,
}
operator_rex = re.compile(r'''(?x)\s*
(?P<key>width|height|tbr|abr|vbr|asr|filesize|filesize_approx|fps)
(?P<key>width|height|shortside|longside|tbr|abr|vbr|asr|filesize|filesize_approx|fps)
\s*(?P<op>%s)(?P<none_inclusive>\s*\?)?\s*
(?P<value>[0-9.]+(?:[kKmMgGtTpPeEzZyY]i?[Bb]?)?)
$
Expand Down Expand Up @@ -1495,6 +1496,8 @@ def _merge(formats_info):
formats_info[1].get('format_id')),
'width': formats_info[0].get('width'),
'height': formats_info[0].get('height'),
'longside': formats_info[0].get('longside'),
'shortside': formats_info[0].get('shortside'),
'resolution': formats_info[0].get('resolution'),
'fps': formats_info[0].get('fps'),
'vcodec': formats_info[0].get('vcodec'),
Expand Down Expand Up @@ -1624,6 +1627,17 @@ def sanitize_numeric_fields(info):
sanitize_string_field(info_dict, 'id')
sanitize_numeric_fields(info_dict)

def add_calculated_video_proprties(fmt):
if type(fmt) is not dict: return
dims = [fmt.get(side) for side in ('width', 'height',)]
dims = [n for n in dims if n is not None]
if len(dims):
fmt['shortside'] = min(iter(dims))
fmt['longside'] = max(iter(dims))

for fmt in [info_dict] + (info_dict.get('formats') or []):
add_calculated_video_proprties(fmt)

if 'playlist' not in info_dict:
# It isn't part of a playlist
info_dict['playlist'] = None
Expand Down

0 comments on commit 5a2aca1

Please sign in to comment.