-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Preserve HTML data attributes (from spans to anchors) #42
Conversation
Ah, adding |
Could you explain to me, I actually don't know what kind of issues this would be. No, I didn't predict this. I only meant if you need to parse the attributes but apparently that's not even needed 🙂 |
Well, autorefs sets |
Ah yes for sure multiple |
My first instinct is to still double down on regexes and require the class attribute to come first 🤪 (well, second) |
The reason that is it's still ok to do this is because all usages should be programmatic and we can still have strict requirements on them |
Commit oprypin@10d76d3 works accordingly |
I've personally written autoref spans manually on a few occurrences 😄 I've pushed your commit on this branch, thanks! LGTM so will merge once CI passes. |
Closes #41
(will squash to add you as co-author @oprypin)