[butterknife-fragments] fix: add missing unbinding

mkoslacz · Jul 27, 2017 · 7269b5f · 7269b5f
1 parent e36dae5
commit 7269b5f
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 4 deletions.
diff --git a/...szkoslacz/moviper/base/view/fragment/autoinject/butterknife/ViperButterKnifeFragment.java b/...szkoslacz/moviper/base/view/fragment/autoinject/butterknife/ViperButterKnifeFragment.java
@@ -9,6 +9,7 @@
 import com.mateuszkoslacz.moviper.iface.view.ViperView;
 
 import butterknife.ButterKnife;
+import butterknife.Unbinder;
 
 /**
  * Created by mateuszkoslacz on 14.12.2016.
@@ -20,9 +21,17 @@ public abstract class ViperButterKnifeFragment
         extends ViperAiFragment<ViewType, Presenter>
         implements ViperView {
 
+    private Unbinder unbinder;
+
     @Override
     protected void injectViews(View view) {
         super.injectViews(view);
-        ButterKnife.bind(this, view);
+        unbinder = ButterKnife.bind(this, view);
+    }
+
+    @Override
+    public void onDestroyView() {
+        super.onDestroyView();
+        unbinder.unbind();
     }
 }
diff --git a/...oslacz/moviper/base/view/fragment/autoinject/butterknife/ViperButterKnifeLceFragment.java b/...oslacz/moviper/base/view/fragment/autoinject/butterknife/ViperButterKnifeLceFragment.java
@@ -9,6 +9,7 @@
 import com.mateuszkoslacz.moviper.iface.view.ViperView;
 
 import butterknife.ButterKnife;
+import butterknife.Unbinder;
 
 /**
  * Created by mateuszkoslacz on 14.12.2016.
@@ -22,9 +23,17 @@ public abstract class ViperButterKnifeLceFragment
         extends ViperLceAiFragment<ContentView, Model, ViewType, Presenter>
         implements ViperLceView<Model> {
 
+    private Unbinder unbinder;
+
     @Override
     protected void injectViews(View view) {
         super.injectViews(view);
-        ButterKnife.bind(this, view);
+        unbinder = ButterKnife.bind(this, view);
+    }
+
+    @Override
+    public void onDestroyView() {
+        super.onDestroyView();
+        unbinder.unbind();
     }
 }
diff --git a/...base/view/fragment/autoinject/passive/butterknife/ViperButterKnifeLcePassiveFragment.java b/...base/view/fragment/autoinject/passive/butterknife/ViperButterKnifeLcePassiveFragment.java
@@ -7,6 +7,7 @@
 import com.mateuszkoslacz.moviper.iface.view.ViperLceView;
 
 import butterknife.ButterKnife;
+import butterknife.Unbinder;
 
 /**
  * Created by mateuszkoslacz on 14.12.2016.
@@ -19,9 +20,17 @@ public abstract class ViperButterKnifeLcePassiveFragment
         extends ViperLceAiPassiveFragment<ContentView, Model, ViewType>
         implements ViperLceView<Model> {
 
+    private Unbinder unbinder;
+
     @Override
     protected void injectViews(View view) {
         super.injectViews(view);
-        ButterKnife.bind(this, view);
+        unbinder = ButterKnife.bind(this, view);
+    }
+
+    @Override
+    public void onDestroyView() {
+        super.onDestroyView();
+        unbinder.unbind();
     }
 }
diff --git a/...er/base/view/fragment/autoinject/passive/butterknife/ViperButterKnifePassiveFragment.java b/...er/base/view/fragment/autoinject/passive/butterknife/ViperButterKnifePassiveFragment.java
@@ -7,6 +7,7 @@
 import com.mateuszkoslacz.moviper.iface.view.ViperView;
 
 import butterknife.ButterKnife;
+import butterknife.Unbinder;
 
 /**
  * Created by mateuszkoslacz on 14.12.2016.
@@ -17,9 +18,17 @@ public abstract class ViperButterKnifePassiveFragment
         extends ViperAiPassiveFragment<ViewType>
         implements ViperView {
 
+    private Unbinder unbinder;
+
     @Override
     protected void injectViews(View view) {
         super.injectViews(view);
-        ButterKnife.bind(this, view);
+        unbinder = ButterKnife.bind(this, view);
+    }
+
+    @Override
+    public void onDestroyView() {
+        super.onDestroyView();
+        unbinder.unbind();
     }
 }