Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use max tokens from options in mlx_lm evaluate #1302

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Use max tokens from options in mlx_lm evaluate #1302

merged 1 commit into from
Feb 26, 2025

Conversation

awni
Copy link
Member

@awni awni commented Feb 26, 2025

  • Better default limit in evaluation
  • Check if max tokens are in generation options

Closes #1288

angeloskath
angeloskath approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awni awni merged commit 0f240a4 into main Feb 26, 2025
2 checks passed
@awni awni deleted the use_option_max_tokens branch February 26, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

@barronalex barronalex Awaiting requested review from barronalex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] mlx_lm.evaluate ignores max_gen_toks configuration
2 participants
@awni @angeloskath