Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shell script to replace the PrepareMetalHeaders plugin #163

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

louen
Copy link
Contributor

@louen louen commented Nov 20, 2024

This PR is a fix for issue #156.
It replaces the swift package build plugin PrepareMetalShaders with a shell script run by the package maintainer.

The shell script can be run as standalone; as set up it is called from update-mlx.sh

  • ran update-mlx.sh and `pre-commit
  • checked the new package builds with Xcode (compiled the libraries and rand example app)
  • checked the newly generated folder is exactly the same than the one coming out of PrepareMetalShaders
  • new shell script passes shellcheck without errors or warnings

Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!!

@davidkoski davidkoski merged commit eaa3041 into ml-explore:main Nov 20, 2024
3 checks passed
@louen louen deleted the val/fix_headers_script branch November 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants