Feature: Implement statistics endpoint #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @JNKielmann, thanks for the contribution 🙂 This looks good to me! Though I think it would be good to have also a test written for that endpoint. Hence, for now I would keep the PR open so that a test can directly committed into the PR. |
|
This looks good for me as well. It might need some caching in the future, but I think this is not necessary for the current state. |
JNKielmann
force-pushed
the
feature/statistics-endpoint
branch
from
81b72c2 to
78bd5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statistics endpoint was not yet implemented, so I though it would be a good task to get more familiar with the code base.
I call the list method of the respective manager and count the result to get the number of projects, users, service, ...
To list all projects (and not just the ones the user has access to) I used a workaround setting authorized_access to None. Is there a better way to do it?
Happy for any feedback on the implementation :)