Improve and expand the tutorials #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchtr
reviewed
Nov 8, 2023
src/pipeline.ipynb
Outdated
| "try:\n", | ||
| " import fondant\n", | ||
| "except ImportError:\n", | ||
| " logging.warning(\"Please install Fondant from the `requirements.txt` at the root of this repository\")" |
There was a problem hiding this comment.
I would add a cell to install the requirements.txt from the notebook. To make it really bulletproofed.
Co-authored-by: Philippe Moussalli <[email protected]>
PhilippeMoussalli
approved these changes
Nov 8, 2023
mrchtr
approved these changes
Nov 8, 2023
| "\n", | ||
| "from pathlib import Path\n", | ||
| "\n", | ||
| "DockerCompiler().compile(pipeline=pipeline, output_path=\"docker-compose.yml\")\n", |
There was a problem hiding this comment.
Could we still add this to make it work on a M1 machine:
Suggested change
| "DockerCompiler().compile(pipeline=pipeline, output_path=\"docker-compose.yml\")\n", | |
| "import os\n", | |
| "os.environ["DOCKER_DEFAULT_PLATFORM"]="linux/amd64"\n", | |
| "DockerCompiler().compile(pipeline=pipeline, output_path=\"docker-compose.yml\")\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some further improvements to both the notebook and the README. I would like us to update all examples to match this.
Some changes: