-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18 feature create tabtsx component #63
Open
edwaddle
wants to merge
7
commits into
dev
Choose a base branch
from
18-feature-create-tabtsx-component
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a71c3ed
Created Tabs component
edwaddle 82cd503
Got rid of comments and the placeholder I used for the props element
edwaddle 71cb075
Added max width for tabs/ semi responsive, turned tabs into radio but…
edwaddle bfc1ca9
Minor tweaks
edwaddle b96330a
Finalized tab component
edwaddle 43e4ded
added tabs to index.ts in atoms
edwaddle 6cd0d80
Reverted error.tsx back to its original state
edwaddle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import {cn} from '@/lib/cn'; | ||
import React from 'react'; | ||
|
||
interface Props extends React.HTMLAttributes<HTMLInputElement>{ | ||
children?: React.ReactNode; | ||
} | ||
/* | ||
*peer-checked: I have no idea, I don't think its implemented yet | ||
*peer-focus: selected tab | ||
*peer-enabled: the one you're clicking on? | ||
*/ | ||
export const Tab: React.FC<Props> = ({ children, className, ...props }) => { | ||
const [id, setId] = React.useState(''); | ||
React.useEffect(() => setId(Math.random().toString(36).substring(7)), []); | ||
return ( | ||
<span className={cn('block w-[100%] max-w-[120px] text-center')}> | ||
<input {...props} className="peer sr-only" id={id} type="radio"/> | ||
<label | ||
className={cn( | ||
'flex cursor-pointer items-center gap-xs px-md py-sm opacity-25 peer-checked:!opacity-100 peer-checked:border-b-line-width peer-focus:outline-none peer-enabled:hover:opacity-50 peer-enabled:active:opacity-100 peer-enabled:active:border-b-line-width ', | ||
className, | ||
)} | ||
htmlFor={id} | ||
> | ||
{children} | ||
</label> | ||
</span> | ||
|
||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export { Tab as default } from './component'; | ||
export * from './component'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unrelated, make sure to pull dev and
git checkout <source-branch> -- <path/to/file>
to reset the file so that it isn't included in the PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure this file is unchanged in the last commit