Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage information for anonymizer #716

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

sanashah007
Copy link
Contributor

specify what to do when converting from Dicom to Nifti

Fixes #715

Proposed Changes

  • Changed Usage.md documentations to specify what to do when using gandlf_anonymizer to convert from Dicom to Nifti

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

specify what to do when converting from Dicom to Nifti
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati enabled auto-merge August 22, 2023 20:11
@sarthakpati sarthakpati changed the title Update usage.md Update usage Aug 22, 2023
@sarthakpati sarthakpati changed the title Update usage Update usage information for anonymizer Aug 22, 2023
@sarthakpati
Copy link
Collaborator

Thanks for the PR @sanashah007! Please drop a comment when the CLA is done from your end and this can be merged).

@sanashah007
Copy link
Contributor Author

CLA is done!

@sarthakpati sarthakpati merged commit bc72ff0 into mlcommons:master Sep 25, 2023
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting DICOM to NIfTI using Gandlf_Anonymizer requires specifying a .nii.gz output file (not a folder).
2 participants