-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to perform automated spell checking #941
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@sarthakpati check the output of the spellchecker action, this will probably need some more customization, I also have no idea why it complains about yaml extension |
Add a new file called words:
- yml
- yaml
- gandlf
- GaNDLF Update the action to use this file: # previous steps go here
- name: Spellcheck
uses: check-spelling/check-spelling@main
with:
config: .spelling ## this is needed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 92.00% 91.99% -0.02%
==========================================
Files 171 171
Lines 10006 10006
==========================================
- Hits 9206 9205 -1
- Misses 800 801 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@szmazurek it seems like the CI is working, no? Can you please take a look and fix the misspelt words so that we can merge? |
6c40e73
to
f44273e
Compare
Hey @szmazurek is this good to merge? |
Waiting for this to merged before tagging. |
Fixes #ISSUE_NUMBER
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logging
library is being used and noprint
statements are left.