Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DICOM WSI by using OpenSlide #959

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Add support for DICOM WSI by using OpenSlide #959

merged 9 commits into from
Oct 31, 2024

Conversation

benmalef
Copy link
Contributor

@benmalef benmalef commented Oct 30, 2024 •
edited by sarthakpati
Loading

Fixes #ISSUE_NUMBER

Proposed Changes

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title Change the tiffslide to openslide. Change the tiffslide to openslide Oct 31, 2024
sarthakpati
sarthakpati requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Minor comments to address.

Dockerfile-CPU Outdated Show resolved Hide resolved
Dockerfile-ROCm Outdated Show resolved Hide resolved
GANDLF/compute/inference_loop.py Show resolved Hide resolved
GANDLF/data/inference_dataloader_histopath.py Show resolved Hide resolved
GANDLF/data/inference_dataloader_histopath.py Outdated Show resolved Hide resolved
GANDLF/data/patch_miner/opm/patch.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@sarthakpati sarthakpati marked this pull request as ready for review October 31, 2024 18:19
@sarthakpati sarthakpati requested a review from a team as a code owner October 31, 2024 18:19
@sarthakpati sarthakpati changed the title Change the tiffslide to openslide Add support for DICOM WSI by using OpenSlide Oct 31, 2024
@sarthakpati sarthakpati merged commit e69e4d5 into mlcommons:master Oct 31, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmalef @sarthakpati