-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the code related to loss computation #965
Refactor the code related to loss computation #965
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@sarthakpati What is your opinion on the implementation of interface and example loss? When we agree on that I will proceed to port the rest. |
Should this PR not be going into https://github.com/szmazurek/GaNDLF/tree/dev ? |
Could be, but as it is directly related to existing core code I tought that we can update directly here. |
This commit was done without proper git initialization and hence is getting flagged by the CLA bot. Can you rebase this? |
7cecd7d
to
c66820a
Compare
c66820a
to
a9729e5
Compare
Done |
3e04612
to
96b64e4
Compare
Fixes #854
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logging
library is being used and noprint
statements are left.