Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor nits #832

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Minor nits #832

merged 4 commits into from
Feb 10, 2025

Conversation

fsschneider
Copy link
Contributor

Depends on #830 and #831

  • Rename a job in regression_tests_variants. There were two jobs called criteo_resnet_pytorch I believe the latter one should actually be called criteo_embed_init_pytorch.
  • Minor nits to formatting in markdown files (to be consistent with what markdownlint suggests).

@fsschneider fsschneider requested a review from a team as a code owner January 15, 2025 15:15
Copy link

github-actions bot commented Jan 15, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg
Copy link
Contributor

The regression test for variants are in an incomplete state. I think we should probably add all the other workloads to the test or remove the entire test.
Since we will not be using the variants for scoring, we may not need to maintain (and test them). Although if we don't maintain them, we should probably just remove them. Wdyt Frank?

@fsschneider
Copy link
Contributor Author

Yeah, I agree. We probably don't want to maintain them and should thus remove them from the code.
We could double-check this decision in a quick working group decision. And then in a follow-up PR, we could remove the held-out workloads from our codebase.

@priyakasimbeg priyakasimbeg merged commit b356844 into mlcommons:dev Feb 10, 2025
15 of 16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants