This should fix current test error in CI

mldiego · Oct 18, 2023 · e35249b · e35249b
1 parent 22b07fd
commit e35249b
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -32,5 +32,4 @@ jobs:
       - name: Run all tests
         uses: matlab-actions/run-command@v1
         with:
-          command: disp('Running NNV custom testing procedure!'); cd("code/nnv"); addpath(genpath(pwd)); disp(is_container()); disp(pwd);
-          # command: disp('Running NNV custom testing procedure!'); cd("code/nnv"); install; results = runtests('tests', 'IncludeSubfolders', true); assertSuccess(results);
+          command: disp('Running NNV custom testing procedure!'); mkdir('/github_actions-true'); cd("code/nnv"); install; results = runtests('tests', 'IncludeSubfolders', true); assertSuccess(results);
diff --git a/code/nnv/engine/utils/is_container.m b/code/nnv/engine/utils/is_container.m
@@ -7,8 +7,6 @@
             out = 0;
         end
         % 'docker container detected'
-    elseif isfolder('/home/runner/work/') % for GitHub actions
-        out = 1;
     else
         out = 0;
         % 'docker container not detected'

diff --git a/code/nnv/engine/utils/is_github_actions.m b/code/nnv/engine/utils/is_github_actions.m
@@ -0,0 +1,10 @@
+function out = is_github_actions()
+    if isfolder('/github_actions-true')
+        out = 1;
+        % 'github actions detected'
+    else
+        out = 0;
+        % 'github actions not detected'
+    end
+end
+
diff --git a/code/nnv/tests/io/test_io.m b/code/nnv/tests/io/test_io.m
@@ -10,7 +10,7 @@
 
 
 %% Test 3: Load onnx model
-if ~is_container() % importers (support packages) are not installed in MATLAB actions
+if ~is_github_actions() % importers (support packages) are not installed in MATLAB actions
     net_onnx = importONNXNetwork('mobilenetv2-1.0.onnx');
     % net = matlab2nnv(net_onnx);
     % This should get error: 

diff --git a/code/nnv/tests/tutorial/test_all_tutorial.m b/code/nnv/tests/tutorial/test_all_tutorial.m
@@ -3,7 +3,7 @@
 cd ../../examples/Tutorial/NN/'ACAS Xu'/;
 
 %% 1) NN: ACAS Xu (verify_onnx_vnnlib)
-if ~is_container() % importers (support packages) are not installed
+if ~is_github_actions() % importers (support packages) are not installed
     verify_onnx_vnnlib;
 end
 
@@ -51,7 +51,7 @@
 
 %% 14) Other: load models
 cd ../../other;
-if ~is_container() % importers (support packages) are not installed
+if ~is_github_actions() % importers (support packages) are not installed
     load_models;
 end