Reload adb on the fly #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: n/a
Issue: n/a
It no longer attempts to handle service restarts. Issue: #197
This is mostly to make sure AdbOpener can survive server instance changes without much hassle. Issue: #197
It is better suited for handling status changes that are not triggered by any kind of loading. Issue: #197
Instead, it is now possible to subscribe to device changes directly. Issue: n/a
Prior to this commit, AdbDeviceList could only be obtained after ADB initialization. However, the GlobalAdbDeviceList is already independent of the ADB connection, it can be initialized without one and get the connection later. Allowing to obtain the list without wait greatly simplified the AdbOpener's wait-for-device flow, and made it resilient to the adb failure. This is an important step to handle ADB restarts properly. As part of the implementation, AdbDataSourceFactory doesn't require ADB to be obtained as well. Issue: #197
The connection can then be re-established Issue: #197
This gives an option for the user to restart a failed ADB connection without restarting the whole app. Issue: #197
mlopatkin
force-pushed
the
ml/197/reload-adb-on-the-fly
branch
from
ffdaa1e
to
9d3ea2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197