Refactor index workflow to prepare for the tree view #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never unsubscribed the LogModelFilter observer registered by the IndexFilterController. A similar leak happens in BookmarkController, but it never frees itself anyway. Issue: #162
This doesn't work because we don't update other filters when removing. Fixing this makes removal linear, though it is already because the array list has to be compacted. It is unlikely that we're going to have tens of thousands of filters, so having a linear complexity of any filter operation is fine. The only exception is the initialization, where adding the filters one by one may exhibit quadratic behavior. To work around that the loading code is now rewritten. Issue: #374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring rewrites how Index filter is handled. Instead of ad hoc combination of the main filter and the custom filter, we now use the proper customized FilterModel.
Also, fixed #374 along the way.
Part of #162.