Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use child models to implement index filters #378

Merged
merged 12 commits into from
May 14, 2024
Merged

Use child models to implement index filters #378

merged 12 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Separate Mutable and read-only views of FilterModel 

    Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6227779 View commit details
    Browse the repository at this point in the history

  2. Get rid of a questionable pattern in the index window's FilterModel 

    Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    390ca00 View commit details
    Browse the repository at this point in the history

  3. Allow filters that do not actually "filter" 

    This is necessary for the sub-filter implementation, where the actual
filtering logic lives in the submodel.
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    da1686f View commit details
    Browse the repository at this point in the history

  4. Prepare to make FilterFromDialog a data carrier instead of filter 

    This is just a rename

Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    09171a9 View commit details
    Browse the repository at this point in the history

  5. Separate editable data and the filter instance 

    Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    780bc31 View commit details
    Browse the repository at this point in the history

  6. Extract an interface for the FilterFromDialog 

    This allows multiple editable filter implementations.

Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    542f4d3 View commit details
    Browse the repository at this point in the history

  7. Make Dialogs return a completed filter 

    This is necessary to make filter compilation part of toFilter

Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a846b08 View commit details
    Browse the repository at this point in the history

  8. Do not keep enabled/disabled status in the data, only in the filter 

    Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8373c10 View commit details
    Browse the repository at this point in the history

  9. Remove separate predicate compilation step 

    Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a269c95 View commit details
    Browse the repository at this point in the history

  10. Clean up predicate and tooltip compilation 

    Now we cache the compiled predicate in the filter instead. The tooltip
can be computed on the fly, so no compilation is necessary here.

Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8ce02b2 View commit details
    Browse the repository at this point in the history

  11. Add base filter class 

    I'm writing enabled()/disabled() implementation way too often.

Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    14acb0c View commit details
    Browse the repository at this point in the history

  12. Use ChildModelFilter to implement index windows 

    Issue: #162
    @mlopatkin
    mlopatkin committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8034066 View commit details
    Browse the repository at this point in the history