Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brier fix #429

Merged
merged 24 commits into from
Dec 18, 2024
Merged

Brier fix #429

merged 24 commits into from
Dec 18, 2024

Conversation

bblodfon
Copy link
Collaborator

@bblodfon bblodfon commented Dec 11, 2024

Summary

  • Add remove_obs argument to apply t_max cutoff also to the observation level. Before it was hard-coded and behavior was slightly different from original scoring rules.
  • Documentation updates + add some examples in several measures

@bblodfon bblodfon requested a review from adibender December 11, 2024 22:46
@bblodfon bblodfon mentioned this pull request Dec 12, 2024
@bblodfon bblodfon mentioned this pull request Dec 18, 2024
@bblodfon bblodfon merged commit a35a4c4 into main Dec 18, 2024
4 checks passed
@bblodfon bblodfon deleted the brier_fix branch December 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant