Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup script for MLRun CE on Docker/Rancher #156

Open
wants to merge 19 commits into
base: development
Choose a base branch
from

Conversation

adamdelman
Copy link
Member

Setup script for MLRun CE on Docker/Rancher

@adamdelman adamdelman requested a review from liranbg December 23, 2024 09:59
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking hacky and magical, not sure why supporting windows here? I think as while as it works on linux- windows users can use it while using ubuntu on windows to run it

@@ -0,0 +1 @@
MLRUN_HTTPDB__DIRPATH=/Users/adamdelman/mlrun/db
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

@@ -0,0 +1,21 @@
# This script is generated automatically by the release automation code in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

setup_ce.py Outdated
help="Git branch name to check out when upgrading images from the CE repo."
),
debug: bool = typer.Option(
"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"",
False,

otherwise it fails with

Invalid value for '--debug': '' is not a valid boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants