Make encrypted group operation recommendation conditional. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As noted in the discussion about issue #246, I don't think this is the right answer. |
| @@ -915,8 +915,10 @@ While the Application messages will always be encrypted, having the handshake | |||
| messages in plaintext has privacy consequences as someone could | |||
| collect the signatures on the handshake messages and use them for tracking. | |||
|
|
|||
| > **RECOMMENDATION:** Prefer using encrypted group operation messages to avoid | |||
| > privacy issues related to non-encrypted signatures. | |||
| > **RECOMMENDATION:** Prefer using encrypted group operation messages unless a | |||
There was a problem hiding this comment.
Suggested change
| > **RECOMMENDATION:** Prefer using encrypted group operation messages unless a | |
| > **RECOMMENDATION:** Prefer using encrypted handshake messages unless a |
rohanmahy
approved these changes
Mar 6, 2024
Co-authored-by: raphaelrobert <[email protected]>
beurdouche
approved these changes
Mar 6, 2024
|
That is what we actually discussed at the interim... Thanks for the PR. |
|
Please back this out. There wasn't a consensus call on the list, so we shouldn't be landing anything until that happens. |
|
Yeah we should back this out. I'll set something up to finalize this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.