Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#254: Address key material sharing consistently #256

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

Bren2010
Copy link
Contributor

@Bren2010 Bren2010 commented Jun 5, 2024

No description provided.

Copy link
Collaborator

@ekr ekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editorial changes at the beginning of this PR make sense. The substantive changes seem like regressions and I don't think we should make them. If you want to narrow the PR as indicated in the review I'll land it.

provide a synchronization mechanism so that the clients' state remain consistent
across changes to the MLS group. Flaws in this synchronization mechanism may
impair the ability of the user to recover from a compromise of one of their
devices.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text looks good, but I think you need to reinstate the previous text somewhere:

An attacker could use one compromised device to establish ownership of a state across other devices and reduce the ability of the user to recover.

@ekr ekr merged commit fe14434 into mlswg:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants