Add SelfRemove proposal to MLS extensions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkohbrok
suggested changes
Oct 23, 2023
|
|
||
| The design of the MLS protocol prevents a member of | ||
| an MLS group from removing itself immediately from the group. To cause | ||
| an immediate change in the group, a member must send a Commit message. |
There was a problem hiding this comment.
The first of these three sentences seems to be the conclusion of the second and third. Maybe change up the order a bit?
|
|
||
| This document specifies a new MLS Proposal type called `SelfRemove`. Its syntax | ||
| is described using the TLS Presentation Language [@!RFC8446] below (its contents | ||
| is an empty struct). It is allowed in External Commits and requires an UpdatePath. |
There was a problem hiding this comment.
Suggested change
| is an empty struct). It is allowed in External Commits and requires an UpdatePath. | |
| are an empty struct). It is allowed in External Commits and requires an UpdatePath. |
This should be plural, shouldn't it?
draft-ietf-mls-extensions.md
Outdated
| from a self-remove-capable group. Because the point of a | ||
| SelfRemove Proposal is to be available to external joiners | ||
| (which are not yet members), these proposals MUST be sent | ||
| as an MLS PublicMessage. |
There was a problem hiding this comment.
Suggested change
| as an MLS PublicMessage. | |
| as MLS PublicMessages. |
draft-ietf-mls-extensions.md
Outdated
| provides a GroupInfo object to an external joiner, the DS SHOULD attach any | ||
| SelfRemove proposals known to the DS to the GroupInfo object. | ||
|
|
||
| As with Remove proposals, clients need to be prepared to receive the Commit |
There was a problem hiding this comment.
This is a bit unclear to me. What does it mean for a client to be prepared?
rohan-wire
commented
Oct 23, 2023
rohan-wire
commented
Oct 23, 2023
rohan-wire
commented
Oct 23, 2023
rohan-wire
commented
Oct 23, 2023
rohan-wire
commented
Oct 23, 2023
Co-authored-by: Konrad Kohbrok <[email protected]>
kkohbrok
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during IETF 117, this PR corresponds to the text from draft-mahy-mls-selfremove.