Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include definition of ExtensionState extension #26

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

kkohbrok
Copy link
Contributor

@kkohbrok kkohbrok commented Apr 19, 2024

This PR is joint work with @psyoptix, @mulmarta and @raphaelrobert.

@kkohbrok kkohbrok marked this pull request as ready for review April 22, 2024 15:12
@raphaelrobert raphaelrobert merged commit 14332f7 into mlswg:main Jul 22, 2024
1 check passed
@rohanmahy
Copy link
Contributor

Hi, @kkohbrok @psyoptix @mulmarta I realize that this has been approved, however I think it conflates three things:

  • making GroupContext items that are hidden from non-members. This should be encrypted somehow rather than hashed. Hashing just pushes the problem of getting the context somewhere else
  • the ability to patch the GroupContext is a problem we are also trying to solve with the (App)Sync proposal. Again, we don't want a hash here.
  • incorporating GroupState for which the master copy of this data is elsewhere, but we want to have agreement on it. This is a great use of a hash.

@kkohbrok
Copy link
Contributor Author

kkohbrok commented Oct 8, 2024

I'm not sure I understand what you're suggesting here. A couple of points:

  • ExtensionState allows (safe) extensions to safely anchor state in the group context. As such it's a "lower-level" mechanism than AppSync as it's meant to be used by extensions (such as AppSync) rather than an application running on top of MLS.
  • ExtensionState doesn't preclude extensions from storing encrypted data. I agree that hashing isn't necessarily the best way to limit visibility, mostly because the hash might leak data to the DS. I'd be okay with removing that sentence. However, as you point out using ExtensionState to anchor data in hash form is still useful.
  • ExtensionState doesn't prescribe how individual extensions should patch their data. That's by design, as we assume that the extension will handle that in some other way, for example, via extension-defined proposals. So there's no redundancy with what AppSync is trying to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants