add additional credential types #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rohanmahy
commented
Oct 28, 2024
rohanmahy
commented
- add multi and weak-multi credential types
Bren2010
reviewed
Nov 2, 2024
|
|
||
| The `cipher_suite` for a credential is NOT REQUIRED to match the cipher suite | ||
| for the MLS group in which it is used, but MUST meet the support requirements | ||
| with regard to support by group members discussed below. |
There was a problem hiding this comment.
Why would the ciphersuite not match? What is its purpose?
There was a problem hiding this comment.
The idea here is like how you can have an X.509 certificate certifying an ECDSA key that is signed under a CA certificate with an RSA key.
|
As discussed at 20250123 interim, address Brendan's comments and then merge. Also may be refactored as a result of appsync. |
rohanmahy
commented
Jan 23, 2025
Co-authored-by: Rohan Mahy <[email protected]>
bifurcation
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
This looks good to me. I believe we have addressed the comments from @Bren2010 in GitHub comments, so we should be clear to merge.
raphaelrobert
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.