Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/modules/core/transition_mix.c: Increase MAX_CHANNELS to 32 #995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tjoppen
Copy link
Contributor

@Tjoppen Tjoppen commented Jun 19, 2024

This matches filter_audiomap.c

Perhaps this should be a project-wide CMake option? Conform them for now.

@bmatherly
Copy link
Member

Did you consider an approach to change this service to remove the static definition and dynamically allocate and loop based on the number of actual channels? I wonder how hard that would be to do.

@Tjoppen
Copy link
Contributor Author

Tjoppen commented Jun 20, 2024

It probably wouldn't be too hard to do. This is quick and doesn't hurt.

@Tjoppen
Copy link
Contributor Author

Tjoppen commented Jun 20, 2024

Oh and to address your comment in the other PR, this one has been tested and is known to work with filter_audiomap.c. Perhaps rather than doing what #996 does, a common API for reporting channel limits could be introduced? That way there's a way to query it.

@ddennedy
Copy link
Member

doesn't hurt

It increases memory usage on projects with multiple mix transitions. Using my example from the other PR, the project with 100 mix transitions needs 2.3 GiB RAM just for the mix transitions. Do your requirements permit a lower value such 8 - 16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants