fix(tracing): respect mode in R forward function #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized that because TorchScript is statically typed we would need to infer the types for the forward method that selects trainforward or evalforward depending on the mode. We can do this later, but for now I think this fix is also okay. Resolves Issue mlverse#1252
|
@dfalbel once again I need the 'lantern' tag |
dfalbel
added
the
lantern
|
Just added the lantern tag. I also gave you some additional roles in the repository, so you should be able to mark PR labels now. |
|
Tests seem to be passing @dfalbel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that because TorchScript is statically typed, we would need to infer the types for the forward method that selects trainforward or evalforward depending on the mode (if we want to register this method in the C++ ScriptModule).
While I still think this is the cleaner approach, I don't immediately now how to do this, so I would defer this to a later point. For now this also works I think.
Resolves Issue #1252