Newcommands fixes #18 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,Sadd,Scard,Sdiff,Sdiffstore,Select,Setbit,Setrange,Time,Ttl, and Type commands modification of Get, Set, Setnx commands as well as Protocol.java and Redis2TextProtocol.java
Conflicts: src/main/java/com/mmmthatsgoodcode/redis/protocol/command/Del.java
…tocol.java Expire.java and Redis2TextProtocolTest.java
…t filled (TODOs), Tests still need to be done
…,Blpop,Brpop,Commandgetkeys,Commandinfo,Configget, Protocol updated and test OK
…,Blpop,Brpop,Commandgetkeys,Commandinfo,Configget, Protocol updated and test OK
modified: Protocol, Redis2TextProtocol, Redis2TextProtocolTest new Commands: Dbsize, Flushall, Flushdb, Hdel, Hexists, Hget, Hgetall, Hincrby, Hincrbyfloat, Hkeys, Hlen, Hmget, Hset, Hsetnx, Hvals, Incrby, Incrbyfloat, Info
…into newcommands Conflicts: src/main/java/com/mmmthatsgoodcode/redis/protocol/Redis2TextProtocol.java src/test/java/com/mmmthatsgoodcode/redis/protocol/Redis2TextProtocolTest.java
…set,Ltrim,Mget, and Move. Redis2Textprotocol updated and test done
…e,Scriptflush,Scriptkill,Shutdown,Sinter,Sinterstore,Sismember,Smembers,Smove,Spop,Srandmember, Srem,Strlen and Unwatch. Protocol.java and Redist2TextProtocol.java updated, ProtocolTest done.
…, Sunionstore, Zcard, Zrem commands, Redis' protocol updated, and test done. Monitor, Sync and Zrank entities done, but the reply type still has to be defined.=>not added to protocol.
|
can you rebase this from master? |
…exing is not necessary for this command since MSET allways returns "OK". Adapting SplittableCommand for multiplexing, and testing in AbstractClientTest
|
This has the same problem. Can you commit only the changes specific to this issue, to a new branch of master please? |
|
sure, that's what I am working on right now. I just did a Multiplex branch, that implements all we decided about, and was about to push it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Del,Dump,Expireat,Rename,Renamex,Role,Rpop,Rpoplpush,Rpush,Rpushx,Sadd,Scard,Sdiff,Sdiffstore,Select,Setbit,Setrange,Time,Ttl, and Type commands
modification of Get, Set, Setnx commands as well as Protocol.java and Redis2TextProtocol.java