Multiplexed Commands Del, MSet, SInter and SUnion

[loloreyn]

Implementing multiplexed commands (Del, MSet, SInter and SUnion as well as SAdd, which is needed to test SInter and SUnion).

Tests with server done.

[andlaz]

Can you remove this comment..?

[andlaz]

I noticed in tests you are only using assertTrue();
please make liberal use of assertEquals for asserting equivalence, fail() for failing a test on some complex condition ( say in an if-block; but use assertEquals() where possible )

[loloreyn]

about the assertTrue() in Redis2TextProtocol.java, I can't do
assertEquals(execCommandBytes.toByteArray(), encoded);
since it compares the reference of the objects too. but if I do
assertTrue(Arrays.equals(encoded, execCommandBytes.toByteArray()));
the tests pass since it compares the content.

[andlaz]

I don't get this loop.

• If you come upon a MultiBulkReply thats empty, you discard everything and return a new empty "combined" reply
• otherwise you remove all Replies from base that are not in the Reply you are iterating on

I think the original intention here was to create a single MultiBulkReply for the MultiBulkReply objects of the child SInters - how is this fulfilling that?

[loloreyn]

Sinter command returns a set that is an intersection of all the sets asked through the keys. If even one of them is an empty set, the returned set will also be empty. So there is no point in continuing in the loop for x times. You just return an MultiBulkReply that has an empty set as value.

from the redis doc:
Keys that do not exist are considered to be empty sets. With one of the keys being an empty set, the resulting set is also empty (since set intersection with an empty set always results in an empty set).

[andlaz]

Please remove the Multiplexing... test methods from AbstractClientTest. We'll move the existing methods to a benchmark and re-do this class with mocking so it can properly test Client implementations without a Redis connection.