ENH: Fine calibration support for more MEG systems #12966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
drammock,
agramfort and
dengemann
as code owners
|
@drammock is this PR okay with you? It now contains a workaround for scikit-learn/scikit-learn#30268 (comment) that is causing pip-pre to fail |
drammock
approved these changes
Nov 15, 2024
| @@ -43,6 +44,9 @@ def compute_fine_calibration( | |||
| origin=(0.0, 0.0, 0.0), | |||
| cross_talk=None, | |||
| calibration=None, | |||
| *, | |||
| angle_limit=5.0, | |||
| err_limit=5.0, | |||
There was a problem hiding this comment.
AFAICT err_limit isn't validated anywhere, there should at least be some check that it is non-negative right?
| if system == "kit": | ||
| raw = read_raw_kit(sqd_path, mrk_path, elp_path, hsp_path) | ||
| angle_limit = 170 | ||
| err_limit = 500 |
There was a problem hiding this comment.
err_limit is 500% for kit, and 6000% for CTF?
There was a problem hiding this comment.
Yeah I think because these are actually not great segments to be processing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently tried running fine calibration calculation on a non-Neuromag system. It did not work. This PR makes it so it works much better for other systems.