PR: 3주차 과제 - ReactHookForm,BoilerTemplate,Refactor(Jeff) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
원인: ref 미전달 해결: forwardRef 설정
snkchan
reviewed
Mar 24, 2024
boiler-template/src/App.tsx
Outdated
There was a problem hiding this comment.
boiler-template이기때문에 불필요한 파일은 삭제 요청드립니다..
boiler-template/src/main.tsx
Outdated
There was a problem hiding this comment.
util-css에는 styled-components사용을 대비해서 작성해주셨는데 그렇다면 globalStyle파일과 해당 globalStyle을 main.tsx에 적용시킨 부분도 준비돼있으면 어떨까합니다
| className={tailwindMerge( | ||
| SizeVariants[scale], | ||
| 'flex items-center gap-2 h-12 p-1 border-2 rounded-sm border-gray-500 focus-within:border-green-500', | ||
| )} |
There was a problem hiding this comment.
'flex items-center gap-2 h-12 p-1 border-2 rounded-sm border-gray-500 focus-within:border-green-500'
이부분은
에공통으로 적용될 부분인거같은데 merge를통해 뒤에 작성하기보다는
cva를사용하는 방법이 어떨까요?
cva를사용하는 방법이 어떨까요?
rhf/src/components/layout/center.tsx
Outdated
Comment on lines
+10
to
+24
| const { dataList: postList } = useFetchDataListAndPagination({ | ||
| endpoints: FETCH_POINT_DATA_LIST.POST, | ||
| take: 20, | ||
| limit: 10 | ||
| }) | ||
| const { onOpenConfirm } = useDialog() | ||
|
|
||
| const onClickPost = async (postId) => { | ||
| onOpenConfirm('정말로 페이지를 이동하겠습니까', () => { | ||
| onOpenConfirm('정말로 이동해버린다요!', () => { | ||
| navigate(`/post-detail/${postId}`), onCloseDialog() | ||
| }) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
readme에 작성된 dataList요청이 늦어질때 화면에 아무것도 보이지않는 오류가있다는것을 봤었는데
view가 그려지기전에 !dataList라면 return 해주는 코드를 추가해주면 해결되지 않을가요?
아니면 useFectchDataListAndPagination에서 [isLoading,setIsLoading] = useState()선언해주시고
const asyncFetching = async () => {
try{
setIsloading(false)
...{fetching}
}
}
catch(error){
... {error일때 처리}
}
finally{
setIsLoading(true)
}이런식으로도 해결할 수 있을거 같습니다.
react-query사용했을때처럼 말이죠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[진행사항]