PR: 4주차 과제 - Brilly #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjjiyoung0130
changed the title
week4-2,3/README.md
Outdated
There was a problem hiding this comment.
배포된 페이지 들어가 보니까 맨 처음 들어갔을 때만 skeleton ui 나오고
맨 아래로 내려갔을 때는 나오지 않는 이슈가 있습니다.
image-skeleton.mp4
Comment on lines
+3
to
+15
|
|
||
| const fetchingData = promiseWrapper( | ||
| createDelayedPromise("my name is mobi", 5000) | ||
| ); | ||
| // createDelayedPromise : 주어진 시간을 resolve하는 promise 생성 -> 5초 후 값 반환 | ||
| // promiseWrapper : Promise를 래핑하여 해당 Promise가 완료될 때까지 대기할 수 있는 객체를 반환 | ||
|
|
||
| const SpittingLazyLoading = () => { | ||
| const data = fetchingData.read(); | ||
|
|
||
| return <div>{data}</div>; | ||
| }; | ||
| export default SpittingLazyLoading; |
There was a problem hiding this comment.
const fetchingData = promiseWrapper(
createDelayedPromise("my name is mobi", 5000)
);혹시, promiseWrapper 를 컴포넌트 내부에서 실행해 보셨나요??
지금 구조로는,, SpittingLazyLoading 과 상관없이 무조건 실행돼서 일반적으로 사용하는 방법이 아닌 것 같습니다.
안해보셨다면 해 보시길 추천드립니다. 재밌는 일이 생깁니다. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제1 : 핵심 웹 지표의 정의와 개선할 수 있는 방안에 대하여 정리
과제2 : 사이트 배포 및 lightHouse를 활용한 성능 개선 (Pair)
과제3 : Image Load 최적화 생각해보고 Image Lazy load 적용하기 (Pair)
과제4 : 상황에 맞게 suspense를 구현하기
과제5 : react-error-boundary를 사용한 상황별 에러 핸들링
과제6 : vite과 webpack의 빌드 차이 및 장단점 정리