centralized rabbitmq, ocpdb update #291
Merged
+116
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-infinity
force-pushed
the
rabbitmq-and-ocpdb-update
branch
from
364edf5 to
d462fe3
Compare
derhuerst
reviewed
Jan 3, 2025
| # configure an appropriate startup_period, e.g. 60s | ||
| # Otherwise, lamassu might update them only after the | ||
| # Otherwise, lamassu might update them only after the |
There was a problem hiding this comment.
[nitpick]
It would be great if you could remove this unrelated formatting change from the commit(s).
There was a problem hiding this comment.
That's actually auto-cleanup by my IDE, cannot really remove it without disabling that feature completely.
Co-authored-by: Jannis R #38c3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance at rabbitmq by combining the two rabbitmq to one instance, and by improving the healthcheck. Also updates OCPDB to version 1.2