Adds shake command #2259
Open
Adds shake command #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanacostarubio
force-pushed
the
feature/shake
branch
from
9050e69 to
3a95df2
Compare
rtharston
reviewed
Feb 24, 2025
| if (exitCode != 0) { | ||
| val errorStream = process.errorStream.bufferedReader().readText() | ||
| logger.error("Failed to execute shake gesture. Exit code: $exitCode, Error: $errorStream") | ||
| throw IOException("Failed to execute shake gesture on simulator. Exit code: $exitCode") |
There was a problem hiding this comment.
The catch block below will re-throw this with this message wrapped in the same message again:
"Failed to execute shake gesture on simulator: Failed to execute shake gesture on simulator. Exit code: $exitCode"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
It implements the shake command. It closes #1164
AI
copilot:summary
Testing
I was able to test this using my local iOS simulator. However, I'm unsure why it's not working on the Android emulator. I can see the shake happening when I use the terminal to run the adb commands.
Issues fixed