Implement setTimeout/clearTimeout in Maestro's JavaScript Environment #2254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements the standard JavaScript timer functions (
setTimeout
/clearTimeout
) in Maestro's GraalJS environment, which previously didn't include these functions.Changes
GraalJsTimer.kt
GraalJsTimer
class to handle JavaScript timer functionalityAtomicInteger
CountDownLatch
GraalJsEngine.kt
setTimeout
andclearTimeout
functionsOrchestra.kt
Implementation Details
The implementation follows JavaScript's standard timer behavior:
setTimeout(callback, delay, ...args)
returns a numeric timer IDclearTimeout(timeoutId)
cancels a pending timeoutTesting
Tested with various scenarios: