upgrade ruby and capybara and fix tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch to .ruby-version, which is the recommend way to use rvm.
…ersion and small fixes to get this running without error
- needed selenium-webdriver in the development dependencies since it is used in tests - there were a bunch of white spaces at the end of some of these test files - open3 needed to be required when we use it - be_true an be_false is now "be true" and "be false"
TheJefe
force-pushed
the
jk/upgrade_ruby
branch
from
9ced4d4 to
84b97ae
Compare
Tag files are used by editors to quickly search projects, and should be generated locally, never need to check this in. DS_Store is some silly OSx file that annoyingly pops up everywhere
TheJefe
force-pushed
the
jk/upgrade_ruby
branch
from
84b97ae to
321e5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to look at this package, and couldn't use it because the outdated version of ruby can't be installed by rvm on modern versions of OSx.
So this PR
be trueinstead ofbe_truebecausebe_truehas been removed.