detect: fix auto-detection of metric exporters to handle none correctly #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
none-metrics-exporter
branch
from
a580d97 to
30f20d6
Compare
crazy-max
approved these changes
Mar 11, 2024
tonistiigi
reviewed
Mar 11, 2024
The original design for adding metric exporters accidentally relied on the traces exporter variable for enabling or disabling the metrics exporter. It's normal for metrics to get auto-enabled with the same environment variables that traces use, but it should also respond to `none` for disabling. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
none-metrics-exporter
branch
from
30f20d6 to
3947d5b
Compare
tonistiigi
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original design for adding metric exporters accidentally relied on
the traces exporter variable for enabling or disabling the metrics
exporter. It's normal for metrics to get auto-enabled with the same
environment variables that traces use, but it should also respond to
nonefor disabling.Fixes #4743.