allow duration based filters on diskusage requests #5455
Conversation
Allows similar time-based filter that is allowed for prune requests so that DiskUsage request can be used to check which records would be candidates for pruning. Signed-off-by: Tonis Tiigi <[email protected]>
| @@ -36,6 +36,7 @@ message PruneRequest { | |||
|
|
|||
| message DiskUsageRequest { | |||
| repeated string filter = 1; | |||
| int64 ageLimit = 2; | |||
There was a problem hiding this comment.
Struggled to find a good name for this. In Prune it is called KeepDuration but that name does not make sense at all for DiskUsage.
In buildx this is --filter until=<duration> that is detected on client side and converted to another field. buildx du will likely keep the same name there.
There was a problem hiding this comment.
ageLimit SGTM - but if we change this, would it also make sense to change the name in the prune request? We're already making changes to these structs in the next release because of the new storage fields.
There was a problem hiding this comment.
if prune had ageLimit is it obvious which way it works? Eg. is it pruning the things that are newer than ageLimit or older? Correct is older but I don't know if it is obvious.
There was a problem hiding this comment.
I second this, ageLimit is fine for disk usage request. WDYT @dvdksn?
There was a problem hiding this comment.
Alternatively maxAge, we use maxUsedSpace in GC policy.
There was a problem hiding this comment.
maxAge is nice, it works well in both places 🎉
There was a problem hiding this comment.
If anything, I think this is minAge
Allows similar time-based filter that is allowed for prune requests so that DiskUsage request can be used to check which records would be candidates for pruning.