Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple exporter responses #5586

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Multiple exporter responses #5586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf863c1
The initial work on supporting multiple concurrent exporters was
a-palchikov Dec 8, 2024
be230e2
Add a test case to exercise the fact that parallel export in different
a-palchikov Dec 15, 2024
4ae96bc
Use the same ExporterResponse type for cache exporter responses
a-palchikov Dec 18, 2024
18788b5
Add support for disambiguating multiple responses for cache exporters
a-palchikov Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
977 changes: 584 additions & 393 deletions api/services/control/control.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 30 additions & 2 deletions api/services/control/control.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ message PruneRequest {
}

message DiskUsageRequest {
repeated string filter = 1;
repeated string filter = 1;
}

message DiskUsageResponse {
Expand Down Expand Up @@ -102,10 +102,19 @@ message CacheOptionsEntry {
// Attrs are like mode=(min,max), ref=example.com:5000/foo/bar .
// See cache importer/exporter implementations' documentation.
map<string, string> Attrs = 2;
// ID identifies this exporter.
// ID should be treated by the exporter as opaque.
string ID = 3;
}

message SolveResponse {
map<string, string> ExporterResponse = 1;
// ExporterResponseDeprecated is a combined exporter response - it aggregates
// responses from all exporters (including cache exporters) running in parallel.
// It is deprecated in favor of the structured exporter responses but will be
// populated as long as it is supported.
map<string, string> ExporterResponseDeprecated = 1;
repeated ExporterResponse exporterResponses = 2;
repeated ExporterResponse cacheExporterResponses = 3;
}

message StatusRequest {
Expand Down Expand Up @@ -245,4 +254,23 @@ message Exporter {
string Type = 1;
// Attrs specifies exporter configuration
map<string, string> Attrs = 2;
// ID identifies this exporter.
// ID should be treated by the exporter as opaque.
string ID = 3;
}

// ExporterResponse describes the output of an exporter
message ExporterResponse {
// Metadata describes the exporter
ExporterMetadata metadata = 1;
// Data is the exporter's output
map<string, string> data = 2;
}

// ExporterMetadata describes the output exporter
message ExporterMetadata {
// ID identifies the exporter
string ID = 1;
// Type identifies the exporter type
string type = 2;
}
Loading
Loading