Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: missing direct push check feature compat #5661

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

crazy-max
Copy link
Member

we forgot to check feature compat in #5614

relates to: https://github.com/moby/moby/actions/runs/12778000243/job/35622992353?pr=49279#step:13:4311

=== FAIL: frontend/dockerfile TestIntegration/TestPlatformWithOSVersion/worker=dockerd/frontend=client (4.82s)
    dockerfile_test.go:9511: 
        	Error Trace:	/src/frontend/dockerfile/dockerfile_test.go:9511
        	            				/src/util/testutil/integration/run.go:98
        	            				/src/util/testutil/integration/run.go:212
        	Error:      	Received unexpected error:
        	            	exporter "image" could not be found
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:82
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:204
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/api/services/control.(*controlClient).Solve
        	            		/src/api/services/control/control_grpc.pb.go:88
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:269
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700
        	            	failed to solve
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:285
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700

@crazy-max crazy-max merged commit f0d6eea into moby:master Jan 15, 2025
97 checks passed
@crazy-max crazy-max deleted the dockerfile-fix-test branch January 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants