authprovider: Add support for expiring auth cache #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
docker_auth_expire
branch
from
64333ae to
76b18b7
Compare
cpuguy83
force-pushed
the
docker_auth_expire
branch
from
76b18b7 to
be0ce1a
Compare
tonistiigi
reviewed
Jan 27, 2025
| } | ||
| ap.authConfigCache[host] = &ac | ||
| entry, exists := ap.authConfigCache[host] | ||
| if exists && !ap.expireAc(entry.Created, host) { |
There was a problem hiding this comment.
I think some sane expiration defaults in here would be ok. Eg. 10min?
There was a problem hiding this comment.
Updated to use 10min default.
cpuguy83
force-pushed
the
docker_auth_expire
branch
from
be0ce1a to
246572f
Compare
This exposes a mechanism to expire cached auth configs. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
docker_auth_expire
branch
from
246572f to
150e798
Compare
tonistiigi
approved these changes
Jan 28, 2025
|
I'm testing these changes with a private repo to see how this does. |
|
That'll take like 7-9 hours to actually finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a mechanism to expire cached auth configs.