-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codegen for rvalue aggregate raw pointer to an adt with slice tail #3644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to traverse the type, since the tail could be multiple levels down. E.g.:
Wrapper<Wrapper<[u8]>>
I pushed a new patch to this PR. I pulled the code from #3687. Note that I already added the entire |
Co-authored-by: Qinheping Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9c2318b
This change fixes how we compute size of the object in our mem predicates, and provide user visible methods to try to retrieve the size of the object if known and valid (`checked_size_of_raw` and `checked_align_of_raw`. Fixes #3612 Fixes #3627 ## Call-outs To simplify this PR, I moved the following changes to their own PRs: 1. #3644 2. #3718 I also removed the fix for the intrinsics `size_of_val` and `align_of_val` from this PR, and I will create a follow up PR once this one is merged. --------- Co-authored-by: Carolyn Zech <[email protected]>
Updated version in all `Cargo.toml` files (via `find . -name Cargo.toml -exec sed -i 's/version = "0.56.0"/version = "0.57.0"/' {} \;`) and ran `cargo build-dev` to have `Cargo.lock` files updated. GitHub generated release notes: ## What's Changed * Remove the overflow checks for wrapping_offset by @zhassan-aws in model-checking#3589 * `kani-cov`: A coverage tool for Kani by @adpaco-aws in model-checking#3121 * Automatic toolchain upgrade to nightly-2024-10-04 by @github-actions in model-checking#3570 * Automatic toolchain upgrade to nightly-2024-10-05 by @github-actions in model-checking#3591 * Automatic toolchain upgrade to nightly-2024-10-06 by @github-actions in model-checking#3592 * Exclude Charon from workspace by @zhassan-aws in model-checking#3580 * Support fully-qualified --package arguments by @celinval in model-checking#3593 * Automatic toolchain upgrade to nightly-2024-10-07 by @github-actions in model-checking#3595 * Automatic toolchain upgrade to nightly-2024-10-08 by @github-actions in model-checking#3597 * Automatic cargo update to 2024-10-14 by @github-actions in model-checking#3598 * Bump tests/perf/s2n-quic from `17171ec` to `7752afb` by @dependabot in model-checking#3601 * Automatic toolchain upgrade to nightly-2024-10-09 by @github-actions in model-checking#3600 * Automatic toolchain upgrade to nightly-2024-10-10 by @github-actions in model-checking#3602 * Automatic toolchain upgrade to nightly-2024-10-11 by @github-actions in model-checking#3603 * Loop Contracts Annotation for While-Loop by @qinheping in model-checking#3151 * Automatic toolchain upgrade to nightly-2024-10-12 by @github-actions in model-checking#3604 * Update toolchain to 2024-10-15 by @zhassan-aws in model-checking#3605 * Automatic toolchain upgrade to nightly-2024-10-16 by @github-actions in model-checking#3607 * Implement proper function pointer handling for validity checks by @celinval in model-checking#3606 * Update toolchain to 2024-10-17 by @zhassan-aws in model-checking#3610 * Add fn that checks pointers point to same allocation by @celinval in model-checking#3583 * Automatic toolchain upgrade to nightly-2024-10-18 by @github-actions in model-checking#3613 * [aeneas] Preserve variable names by @zhassan-aws in model-checking#3560 * [Breaking change] Make `kani::check` private by @celinval in model-checking#3614 * Emit an error when proof_for_contract function is not found by @zhassan-aws in model-checking#3609 * Automatic toolchain upgrade to nightly-2024-10-19 by @github-actions in model-checking#3617 * Automatic toolchain upgrade to nightly-2024-10-20 by @github-actions in model-checking#3619 * Update test small_slice_eq by @qinheping in model-checking#3618 * Automatic toolchain upgrade to nightly-2024-10-21 by @github-actions in model-checking#3621 * Automatic cargo update to 2024-10-21 by @github-actions in model-checking#3622 * Bump tests/perf/s2n-quic from `7752afb` to `cd0314b` by @dependabot in model-checking#3625 * Update coverage flag in docs by @zhassan-aws in model-checking#3626 * Automatic toolchain upgrade to nightly-2024-10-22 by @github-actions in model-checking#3628 * Automatic toolchain upgrade to nightly-2024-10-23 by @github-actions in model-checking#3635 * Remove dead Option layer from run_piped by @zhassan-aws in model-checking#3634 * Add `free(0)` to codegen of loop contracts by @qinheping in model-checking#3637 * [Lean] Rename user-facing options from Aeneas to Lean by @zhassan-aws in model-checking#3630 * Fix ICE due to mishandling of Aggregate rvalue for raw pointers to trait objects by @carolynzech in model-checking#3636 * Automatic toolchain upgrade to nightly-2024-10-24 by @github-actions in model-checking#3639 * Add regular & fixme tests for function contracts by @celinval in model-checking#3371 * Call `goto-instrument` with `DFCC` only once by @qinheping in model-checking#3642 * Build and include `kani-cov` in the bundle by @adpaco-aws in model-checking#3641 * Fix loop contracts transformation when loops in branching by @qinheping in model-checking#3640 * Update toolchain to 10/25 by @carolynzech in model-checking#3648 * Automatic toolchain upgrade to nightly-2024-10-26 by @github-actions in model-checking#3651 * Automatic toolchain upgrade to nightly-2024-10-27 by @github-actions in model-checking#3652 * Bump tests/perf/s2n-quic from `cd0314b` to `ed9db08` by @dependabot in model-checking#3655 * Automatic cargo update to 2024-10-28 by @github-actions in model-checking#3654 * Automatic toolchain upgrade to nightly-2024-10-28 by @github-actions in model-checking#3653 * Reduce the number of object bits for refcell test by @zhassan-aws in model-checking#3656 * Move any_slice_from_array to kani_core by @qinheping in model-checking#3646 * Upgrade toolchain to 2024-10-29 by @zhassan-aws in model-checking#3658 * Add a timeout option by @zhassan-aws in model-checking#3649 * Upgrade toolchain to 2024-10-30 by @tautschnig in model-checking#3661 * Upgrade Rust toolchain to 2024-10-31 by @zhassan-aws in model-checking#3668 * Upgrade toolchain to 2024-11-01 by @tautschnig in model-checking#3671 * Automatic toolchain upgrade to nightly-2024-11-02 by @github-actions in model-checking#3673 * Implement `Arbitrary` for `Range*` by @c410-f3r in model-checking#3666 * Automatic toolchain upgrade to nightly-2024-11-03 by @github-actions in model-checking#3674 * codegen: Ask the layout if it is uninhabited, not its impl detail by @workingjubilee in model-checking#3675 * Automatic cargo update to 2024-11-04 by @github-actions in model-checking#3677 * Bump tests/perf/s2n-quic from `192de7d` to `65d55a4` by @dependabot in model-checking#3678 * Update dependencies following Audit workflow failure. by @remi-delmas-3000 in model-checking#3680 * Harness output individual files by @Alexander-Aghili in model-checking#3360 * Update Charon submodule to 2024-11-04 by @zhassan-aws in model-checking#3686 * Add support for float_to_int_unchecked by @zhassan-aws in model-checking#3660 * Change `same_allocation` to accept wide pointers by @celinval in model-checking#3684 * Automatic upgrade of CBMC from 6.3.1 to 6.4.0 by @github-actions in model-checking#3689 * Derive `Arbitrary` for enums with a single variant by @AlgebraicWolf in model-checking#3692 * Update cbmc-viewer to 3.10 by @remi-delmas-3000 in model-checking#3683 * Apply loop contracts only if there exists some usage by @qinheping in model-checking#3694 * Remove symtab json support by @celinval in model-checking#3695 * Remove CBMC viewer and visualize option by @zhassan-aws in model-checking#3699 * Ignore derivative in Cargo deny by @qinheping in model-checking#3708 * Upgrade Rust toolchain to 2024-11-08 by @zhassan-aws in model-checking#3703 * Automatic cargo update to 2024-11-11 by @github-actions in model-checking#3704 * Update verify-std-check workflow to enable loop contracts by @qinheping in model-checking#3705 * Automatic toolchain upgrade to nightly-2024-11-09 by @github-actions in model-checking#3709 * Bump tests/perf/s2n-quic from `65d55a4` to `cb41b35` by @dependabot in model-checking#3706 * Add support for f16 and f128 in float_to_int_unchecked intrinsic by @zhassan-aws in model-checking#3701 * Upgrade toolchain to nightly-2024-11-11 by @qinheping in model-checking#3710 * Automatic toolchain upgrade to nightly-2024-11-12 by @github-actions in model-checking#3713 * Update charon submodule by @zhassan-aws in model-checking#3716 * Revert "Ignore derivative in Cargo deny" by @qinheping in model-checking#3712 * Upgrade toolchain to nightly-2024-11-13 by @qinheping in model-checking#3715 * Automatic toolchain upgrade to nightly-2024-11-14 by @github-actions in model-checking#3719 * Automatic toolchain upgrade to nightly-2024-11-15 by @github-actions in model-checking#3720 * Fix codegen for rvalue aggregate raw pointer to an adt with slice tail by @carolynzech in model-checking#3644 * Improve Kani handling of function markers by @celinval in model-checking#3718 * Automatic toolchain upgrade to nightly-2024-11-16 by @github-actions in model-checking#3722 * Automatic toolchain upgrade to nightly-2024-11-17 by @github-actions in model-checking#3724 * Automatic cargo update to 2024-11-18 by @github-actions in model-checking#3723 * Bump tests/perf/s2n-quic from `cb41b35` to `4c3ba69` by @dependabot in model-checking#3725 * Automatic toolchain upgrade to nightly-2024-11-18 by @github-actions in model-checking#3727 * Enable contracts for const generic functions by @qinheping in model-checking#3726 * List Subcommand Improvements by @carolynzech in model-checking#3729 * Automatic toolchain upgrade to nightly-2024-11-19 by @github-actions in model-checking#3730 * add support for enum, struct, tuple in llbc backend by @thanhnguyen-aws in model-checking#3721 * Fix issues with how we compute DST size by @celinval in model-checking#3687 * Bump tests/perf/s2n-quic from `4c3ba69` to `c84ba19` by @dependabot in model-checking#3736 * Fix size and alignment computation for intrinsics by @celinval in model-checking#3734 * Automatic cargo update to 2024-11-25 by @github-actions in model-checking#3735 * Cleanup a few internal compiler deps by @celinval in model-checking#3739 * Add a Kani function that checks if the range of a float is valid for conversion to int by @zhassan-aws in model-checking#3742 * Dropping support for Ubuntu 18.04 / AL2. by @thanhnguyen-aws in model-checking#3744 * Update toolchain to nightly-2024-11-26 by @celinval in model-checking#3740 * Automatic upgrade of CBMC from 6.4.0 to 6.4.1 by @github-actions in model-checking#3748 * Automatic cargo update to 2024-12-02 by @github-actions in model-checking#3749 * Update download-artifact, upload-artifact and checkout to v4 by @thanhnguyen-aws in model-checking#3745 * Bump tests/perf/s2n-quic from `c84ba19` to `96d2e22` by @dependabot in model-checking#3750 * Upgrade toolchain to 2024-11-27 by @tautschnig in model-checking#3751 * Upgrade toolchain to 2024-11-28 by @tautschnig in model-checking#3753 * Setup/CI: cleanup Ubuntu 18.04 and cbmc-viewer left-overs and enable 24.04 by @tautschnig in model-checking#3758 * Automatic cargo update to 2024-12-09 by @github-actions in model-checking#3766 * Bump tests/perf/s2n-quic from `96d2e22` to `e4a2365` by @dependabot in model-checking#3767 * Upgrade toolchain to 2024-12-09 by @carolynzech in model-checking#3768 * Add out of bounds check for `offset` intrinsics by @celinval in model-checking#3755 * Upgrade toolchain to 2024-12-12 by @carolynzech in model-checking#3774 * Automatic toolchain upgrade to nightly-2024-12-13 by @github-actions in model-checking#3775 ## New Contributors * @c410-f3r made their first contribution in model-checking#3666 * @workingjubilee made their first contribution in model-checking#3675 * @Alexander-Aghili made their first contribution in model-checking#3360 * @AlgebraicWolf made their first contribution in model-checking#3692 * @thanhnguyen-aws made their first contribution in model-checking#3721 **Full Changelog**: model-checking/kani@kani-0.56.0...kani-0.57.0
Updated version in all `Cargo.toml` files (via `find . -name Cargo.toml -exec sed -i 's/version = "0.56.0"/version = "0.57.0"/' {} \;`) and ran `cargo build-dev` to have `Cargo.lock` files updated. GitHub generated release notes: ## What's Changed * Remove the overflow checks for wrapping_offset by @zhassan-aws in #3589 * `kani-cov`: A coverage tool for Kani by @adpaco-aws in #3121 * Automatic toolchain upgrade to nightly-2024-10-04 by @github-actions in #3570 * Automatic toolchain upgrade to nightly-2024-10-05 by @github-actions in #3591 * Automatic toolchain upgrade to nightly-2024-10-06 by @github-actions in #3592 * Exclude Charon from workspace by @zhassan-aws in #3580 * Support fully-qualified --package arguments by @celinval in #3593 * Automatic toolchain upgrade to nightly-2024-10-07 by @github-actions in #3595 * Automatic toolchain upgrade to nightly-2024-10-08 by @github-actions in #3597 * Automatic cargo update to 2024-10-14 by @github-actions in #3598 * Bump tests/perf/s2n-quic from `17171ec` to `7752afb` by @dependabot in #3601 * Automatic toolchain upgrade to nightly-2024-10-09 by @github-actions in #3600 * Automatic toolchain upgrade to nightly-2024-10-10 by @github-actions in #3602 * Automatic toolchain upgrade to nightly-2024-10-11 by @github-actions in #3603 * Loop Contracts Annotation for While-Loop by @qinheping in #3151 * Automatic toolchain upgrade to nightly-2024-10-12 by @github-actions in #3604 * Update toolchain to 2024-10-15 by @zhassan-aws in #3605 * Automatic toolchain upgrade to nightly-2024-10-16 by @github-actions in #3607 * Implement proper function pointer handling for validity checks by @celinval in #3606 * Update toolchain to 2024-10-17 by @zhassan-aws in #3610 * Add fn that checks pointers point to same allocation by @celinval in #3583 * Automatic toolchain upgrade to nightly-2024-10-18 by @github-actions in #3613 * [aeneas] Preserve variable names by @zhassan-aws in #3560 * [Breaking change] Make `kani::check` private by @celinval in #3614 * Emit an error when proof_for_contract function is not found by @zhassan-aws in #3609 * Automatic toolchain upgrade to nightly-2024-10-19 by @github-actions in #3617 * Automatic toolchain upgrade to nightly-2024-10-20 by @github-actions in #3619 * Update test small_slice_eq by @qinheping in #3618 * Automatic toolchain upgrade to nightly-2024-10-21 by @github-actions in #3621 * Automatic cargo update to 2024-10-21 by @github-actions in #3622 * Bump tests/perf/s2n-quic from `7752afb` to `cd0314b` by @dependabot in #3625 * Update coverage flag in docs by @zhassan-aws in #3626 * Automatic toolchain upgrade to nightly-2024-10-22 by @github-actions in #3628 * Automatic toolchain upgrade to nightly-2024-10-23 by @github-actions in #3635 * Remove dead Option layer from run_piped by @zhassan-aws in #3634 * Add `free(0)` to codegen of loop contracts by @qinheping in #3637 * [Lean] Rename user-facing options from Aeneas to Lean by @zhassan-aws in #3630 * Fix ICE due to mishandling of Aggregate rvalue for raw pointers to trait objects by @carolynzech in #3636 * Automatic toolchain upgrade to nightly-2024-10-24 by @github-actions in #3639 * Add regular & fixme tests for function contracts by @celinval in #3371 * Call `goto-instrument` with `DFCC` only once by @qinheping in #3642 * Build and include `kani-cov` in the bundle by @adpaco-aws in #3641 * Fix loop contracts transformation when loops in branching by @qinheping in #3640 * Update toolchain to 10/25 by @carolynzech in #3648 * Automatic toolchain upgrade to nightly-2024-10-26 by @github-actions in #3651 * Automatic toolchain upgrade to nightly-2024-10-27 by @github-actions in #3652 * Bump tests/perf/s2n-quic from `cd0314b` to `ed9db08` by @dependabot in #3655 * Automatic cargo update to 2024-10-28 by @github-actions in #3654 * Automatic toolchain upgrade to nightly-2024-10-28 by @github-actions in #3653 * Reduce the number of object bits for refcell test by @zhassan-aws in #3656 * Move any_slice_from_array to kani_core by @qinheping in #3646 * Upgrade toolchain to 2024-10-29 by @zhassan-aws in #3658 * Add a timeout option by @zhassan-aws in #3649 * Upgrade toolchain to 2024-10-30 by @tautschnig in #3661 * Upgrade Rust toolchain to 2024-10-31 by @zhassan-aws in #3668 * Upgrade toolchain to 2024-11-01 by @tautschnig in #3671 * Automatic toolchain upgrade to nightly-2024-11-02 by @github-actions in #3673 * Implement `Arbitrary` for `Range*` by @c410-f3r in #3666 * Automatic toolchain upgrade to nightly-2024-11-03 by @github-actions in #3674 * codegen: Ask the layout if it is uninhabited, not its impl detail by @workingjubilee in #3675 * Automatic cargo update to 2024-11-04 by @github-actions in #3677 * Bump tests/perf/s2n-quic from `192de7d` to `65d55a4` by @dependabot in #3678 * Update dependencies following Audit workflow failure. by @remi-delmas-3000 in #3680 * Harness output individual files by @Alexander-Aghili in #3360 * Update Charon submodule to 2024-11-04 by @zhassan-aws in #3686 * Add support for float_to_int_unchecked by @zhassan-aws in #3660 * Change `same_allocation` to accept wide pointers by @celinval in #3684 * Automatic upgrade of CBMC from 6.3.1 to 6.4.0 by @github-actions in #3689 * Derive `Arbitrary` for enums with a single variant by @AlgebraicWolf in #3692 * Update cbmc-viewer to 3.10 by @remi-delmas-3000 in #3683 * Apply loop contracts only if there exists some usage by @qinheping in #3694 * Remove symtab json support by @celinval in #3695 * Remove CBMC viewer and visualize option by @zhassan-aws in #3699 * Ignore derivative in Cargo deny by @qinheping in #3708 * Upgrade Rust toolchain to 2024-11-08 by @zhassan-aws in #3703 * Automatic cargo update to 2024-11-11 by @github-actions in #3704 * Update verify-std-check workflow to enable loop contracts by @qinheping in #3705 * Automatic toolchain upgrade to nightly-2024-11-09 by @github-actions in #3709 * Bump tests/perf/s2n-quic from `65d55a4` to `cb41b35` by @dependabot in #3706 * Add support for f16 and f128 in float_to_int_unchecked intrinsic by @zhassan-aws in #3701 * Upgrade toolchain to nightly-2024-11-11 by @qinheping in #3710 * Automatic toolchain upgrade to nightly-2024-11-12 by @github-actions in #3713 * Update charon submodule by @zhassan-aws in #3716 * Revert "Ignore derivative in Cargo deny" by @qinheping in #3712 * Upgrade toolchain to nightly-2024-11-13 by @qinheping in #3715 * Automatic toolchain upgrade to nightly-2024-11-14 by @github-actions in #3719 * Automatic toolchain upgrade to nightly-2024-11-15 by @github-actions in #3720 * Fix codegen for rvalue aggregate raw pointer to an adt with slice tail by @carolynzech in #3644 * Improve Kani handling of function markers by @celinval in #3718 * Automatic toolchain upgrade to nightly-2024-11-16 by @github-actions in #3722 * Automatic toolchain upgrade to nightly-2024-11-17 by @github-actions in #3724 * Automatic cargo update to 2024-11-18 by @github-actions in #3723 * Bump tests/perf/s2n-quic from `cb41b35` to `4c3ba69` by @dependabot in #3725 * Automatic toolchain upgrade to nightly-2024-11-18 by @github-actions in #3727 * Enable contracts for const generic functions by @qinheping in #3726 * List Subcommand Improvements by @carolynzech in #3729 * Automatic toolchain upgrade to nightly-2024-11-19 by @github-actions in #3730 * add support for enum, struct, tuple in llbc backend by @thanhnguyen-aws in #3721 * Fix issues with how we compute DST size by @celinval in #3687 * Bump tests/perf/s2n-quic from `4c3ba69` to `c84ba19` by @dependabot in #3736 * Fix size and alignment computation for intrinsics by @celinval in #3734 * Automatic cargo update to 2024-11-25 by @github-actions in #3735 * Cleanup a few internal compiler deps by @celinval in #3739 * Add a Kani function that checks if the range of a float is valid for conversion to int by @zhassan-aws in #3742 * Dropping support for Ubuntu 18.04 / AL2. by @thanhnguyen-aws in #3744 * Update toolchain to nightly-2024-11-26 by @celinval in #3740 * Automatic upgrade of CBMC from 6.4.0 to 6.4.1 by @github-actions in #3748 * Automatic cargo update to 2024-12-02 by @github-actions in #3749 * Update download-artifact, upload-artifact and checkout to v4 by @thanhnguyen-aws in #3745 * Bump tests/perf/s2n-quic from `c84ba19` to `96d2e22` by @dependabot in #3750 * Upgrade toolchain to 2024-11-27 by @tautschnig in #3751 * Upgrade toolchain to 2024-11-28 by @tautschnig in #3753 * Setup/CI: cleanup Ubuntu 18.04 and cbmc-viewer left-overs and enable 24.04 by @tautschnig in #3758 * Automatic cargo update to 2024-12-09 by @github-actions in #3766 * Bump tests/perf/s2n-quic from `96d2e22` to `e4a2365` by @dependabot in #3767 * Upgrade toolchain to 2024-12-09 by @carolynzech in #3768 * Add out of bounds check for `offset` intrinsics by @celinval in #3755 * Upgrade toolchain to 2024-12-12 by @carolynzech in #3774 * Automatic toolchain upgrade to nightly-2024-12-13 by @github-actions in #3775 ## New Contributors * @c410-f3r made their first contribution in #3666 * @workingjubilee made their first contribution in #3675 * @Alexander-Aghili made their first contribution in #3360 * @AlgebraicWolf made their first contribution in #3692 * @thanhnguyen-aws made their first contribution in #3721 **Full Changelog**: kani-0.56.0...kani-0.57.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Zyad Hassan <[email protected]> Co-authored-by: Carolyn Zech <[email protected]>
Fix the codegen for a raw pointer to a dynamically-sized ADT. Traverse the type until we find the tail, which will either be a trait object or a slice, and generate the pointer accordingly.
Resolves #3638, #3615
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.