Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charon submodule #3801

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

zhassan-aws
Copy link
Contributor

@zhassan-aws zhassan-aws commented Dec 30, 2024

Update Charon submodule to AeneasVerif/charon@adc0a85

Relevant Charon PRs:
AeneasVerif/charon#457: This required updating the code that creates places to also pass in the type.
AeneasVerif/charon#464: This replaced the file-to-id hash table by a vector, thus requiring that we add one in Kani's translation context.
AeneasVerif/charon#474: The translation context is no longer parameterized by a lifetime
AeneasVerif/charon#491: This required changing the type of indices

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws marked this pull request as ready for review January 2, 2025 19:28
@zhassan-aws zhassan-aws requested a review from a team as a code owner January 2, 2025 19:28
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion for next time, maybe list the charon's API changes that impact Kani to provide more context to the review. Thanks!

@zhassan-aws
Copy link
Contributor Author

Good idea. I updated the PR description with the relevant PRs.

@zhassan-aws zhassan-aws enabled auto-merge January 3, 2025 01:39
@zhassan-aws zhassan-aws added this pull request to the merge queue Jan 3, 2025
Merged via the queue into model-checking:main with commit 91a41ea Jan 3, 2025
26 of 28 checks passed
@zhassan-aws zhassan-aws deleted the charon-2024-12-30 branch January 3, 2025 02:57
github-merge-queue bot pushed a commit that referenced this pull request Jan 11, 2025
## What's Changed
* Package Docker release step: ensure compiler is installed by
@tautschnig in #3789
* Improve `--jobs` UI by @carolynzech in
#3790
* Update kissat to v4.0.1 by @remi-delmas-3000 in
#3791
* Automatic cargo update to 2024-12-23 by @github-actions in
#3792
* Bump tests/perf/s2n-quic from `0b3f892` to `a54686e` by @dependabot in
#3793
* Upgrade toolchain to nightly-2024-12-18 by @zhassan-aws in
#3794
* Automatic cargo update to 2024-12-30 by @github-actions in
#3800
* fix: clippy by @ShoyuVanilla in
#3806
* Update dependencies (02.01.2025). by @remi-delmas-3000 in
#3809
* Update charon submodule by @zhassan-aws in
#3801
* Upgrade toolchain to 2024-12-19 by @zhassan-aws in
#3810
* Automatic cargo update to 2025-01-06 by @github-actions in
#3812
* Bump tests/perf/s2n-quic from `a54686e` to `ac52a48` by @dependabot in
#3813
* Generate contracts of dependencies as assertions by @carolynzech in
#3802
* Fix hanging command in `std-analysis.sh` by @carolynzech in
#3818
* Add UB checks for ptr_offset_from* intrinsics by @celinval in
#3757
* Toolchain update 06-01-2025 by @remi-delmas-3000 in
#3814
* Automatic toolchain upgrade to nightly-2025-01-07 by @github-actions
in #3820
* Include manifest-path when checking if packages are in the workspace
by @qinheping in #3819

## New Contributors
* @ShoyuVanilla made their first contribution in
#3806

**Full Changelog**:
kani-0.57.0...kani-0.58.0

---------

Co-authored-by: Celina G. Val <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants