Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts & Harnesses for write_volatile #167

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Contracts & Harnesses for write_volatile #167

merged 11 commits into from
Dec 3, 2024

Conversation

Jimmycreative
Copy link

@Jimmycreative Jimmycreative commented Nov 15, 2024 •
edited
Loading

Hi

Towards #53

I have completed the write_volatile api. Any suggestion? Thanks

SUMMARY:
 ** 0 of 160 failed (1 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 51.912766s

Complete - 1 successfully verified harnesses, 0 failures, 1 total.

@Jimmycreative Jimmycreative requested a review from a team as a code owner November 15, 2024 23:04
zhassan-aws
zhassan-aws reviewed Nov 15, 2024
View reviewed changes
library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved
library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved
library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved
library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved
library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved
@zhassan-aws zhassan-aws self-assigned this Nov 15, 2024
zhassan-aws
zhassan-aws reviewed Nov 25, 2024
View reviewed changes
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can we add harnesses for other types, e.g. u8, u16, etc? You can use a macro to generate harnesses for integer types.

Can we also add a harness for a zero-sized type, e.g. ()?

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved
zhassan-aws
zhassan-aws approved these changes Dec 2, 2024
View reviewed changes
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhassan-aws
Copy link

Can you resolve the conflicts?

@Jimmycreative
Copy link
Author

Complete resolving the conflict

@zhassan-aws zhassan-aws enabled auto-merge (squash) December 2, 2024 23:34
@zhassan-aws zhassan-aws merged commit db71987 into model-checking:main Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhassan-aws zhassan-aws zhassan-aws approved these changes

@robdockins robdockins Awaiting requested review from robdockins

Assignees

@Jimmycreative Jimmycreative

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jimmycreative @zhassan-aws @robdockins