-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat and improve RAG module and agents #184
Conversation
Persist function added.
persist function added.
…dd a guide agent.
Enhance RAG example
copilot dialog agents update
update as comments suggest (for docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comments.
The current version of rag is not compatible with distributed mode. We can add support in future PRs
update as comments
…s used in previous versions, but no longer needed.
# Conflicts: # examples/conversation_with_RAG_agents/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see inline comments
examples/conversation_with_RAG_agents/configs/agent_config.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz see inline comments
…s used in previous versions, but no longer needed.
address comments
# Conflicts: # setup.py
The ImportError of LlamaIndex library is still exposed to users who don't use RAG module. |
…opilot # Conflicts: # examples/conversation_with_RAG_agents/rag_example.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updates
Changes on code structure
llama-index
asrag_requires
insetup.py
Changes on the RAG agent module
KnowledgeBank
featureKnowledgeBank
membersChanges on the RAG/knowledge module
Improving utility of knowledge module
KnowledgeBank
KnowledgeBank
:KnowledgeBank
provides an easier way to initialize a knowledge object, just calladd_data_as_knowledge
withknowledge_id
(a string as the identifier for this knowledge object),emb_model_name
(the name of the embedding model config) anddata_dirs_and_types
(a dictionary of data directories and the wanted file extensions). As shown in therag_example.py
KnowledgeBank
can be shared and duplicated by multiple agents, which can avoid embedding duplicated documents."knowledge_id"
inknowledge_config.json
) with associated retrievers to perform multi-source information retrieval. Just need to pass the agent intoKnowledgeBank.equip
function.Toturial
Both English and Chinese tutorial are added as 209-rag.md .
Checklist
Please check the following items before code is ready to be reviewed.