Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game gomoku tested model update #247

Merged
merged 42 commits into from
May 24, 2024
Merged

Conversation

zyzhang1130
Copy link
Contributor

@zyzhang1130 zyzhang1130 commented May 22, 2024


name: Pull Request
about: Create a pull request

Description

updated the tested wrappers/models for the example [game_gomoku](https://github.com/modelscope/agentscope/tree/main/examples/game_gomoku)

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

zyzhang1130 and others added 30 commits April 19, 2024 14:45
…d local hugging face model and finetune loaded model with hugging face dataset

Added features to download models from hugging face model hub/load local hugging face model and finetune loaded model with hugging face dataset. Model loading and fine-tuning can happen both at the initialization stage and after the agent has been initialized (see README in `agentscope/examples/load_finetune_huggingface_model` for details). Major changes to the repo include creating the example script `load_finetune_huggingface_model`, adding a new model wrapper `HuggingFaceWrapper`, and creating a new agent type Finetune_DialogAgent. All changes are done in a new example directory `agentscope/examples/load_finetune_huggingface_model`.
made customized hyperparameters specification available from `model_configs` for fine-tuning at initialization, or through `fine_tune_config` in `Finetune_DialogAgent`'s `fine_tune` method after initialization
fixed issue related to `format` method
updated the dependencies needed
update tested models
updated tested models
updated tested models for the example `game_gomoku`
@zyzhang1130 zyzhang1130 marked this pull request as ready for review May 22, 2024 14:05
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

examples/game_gomoku/main.ipynb Outdated Show resolved Hide resolved
examples/game_gomoku/main.ipynb Outdated Show resolved Hide resolved
examples/game_gomoku/main.ipynb Outdated Show resolved Hide resolved
@DavdGao DavdGao requested a review from ZiTao-Li May 24, 2024 05:47
@zyzhang1130
Copy link
Contributor Author

zyzhang1130 commented May 24, 2024

Please see inline comments.

After some checking, it seems whenever I make changes in jupyter notebook (even just in markdown) and recompile them, the metadata will be updated. So I did the update directly on Git Hub this time and now it seems fine.

Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit 218a1a2 into modelscope:main May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants